Open
Conversation
partik03
reviewed
Apr 5, 2023
Comment on lines
+25
to
+26
| const dummyFile = process.cwd() + "/dummyClasses/do.js"; | ||
|
|
Contributor
There was a problem hiding this comment.
Why you are using the dummy class of digital ocean here.Is the dummy class for Oracle same as the class of digital ocean?
| if (/^[A-Z]*$/.test(serviceName)) { | ||
| filePath = | ||
| process.cwd() + | ||
| "/generatedClasses/DO/" + |
Contributor
There was a problem hiding this comment.
Why saving the generated classes in the DO folder?
| process.cwd() + | ||
| "/generatedClasses/DO/" + | ||
| dir + | ||
| "/do-" + |
| } else { | ||
| filePath = | ||
| process.cwd() + | ||
| "/generatedClasses/DO/" + |
Author
There was a problem hiding this comment.
I did not have any prior experience with the dummy classes for Oracle cloud at the time of my earlier response. However, I have since worked on them, made necessary corrections, and currently, I am working on the transformer component.
Author
There was a problem hiding this comment.
Dummy class for oracle #161
And I am currently working on building the transformer for Oracle Cloud.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #157
-Installed and analyzed the Oracle Cloud SDK.
-Created Parser, added tests and Added Oracle as a service provider in yml file.