Fix Slack notification snippet#45
Conversation
We need the snippet to show information about issues and PRs from all repositories in which we typically accept contributions.
ozer550
left a comment
ozer550
left a comment
There was a problem hiding this comment.
The code seems fine, just one question regarding pagination!
scripts/utils.js
Outdated
| async function hasLabel(name, owner, repo, issueNumber, github, core) { | ||
| let labels = []; | ||
| try { | ||
| const response = await github.rest.issues.listLabelsOnIssue({ |
There was a problem hiding this comment.
Just one question here the data received is it paginated? Do we get all the issues in one go?
There was a problem hiding this comment.
Do we get all the issues in one go?
We're fetching only one issue here - by the issue number.
There was a problem hiding this comment.
As for labels, I will look into it
scripts/utils.js
Outdated
| async function getIssues(assignee, state, owner, repos, github, core) { | ||
| const promises = repos.map(repo => | ||
| github.rest.issues | ||
| .listForRepo({ |
There was a problem hiding this comment.
Same for this and getPullRequests function as well? If we are getting a limited amount of issues in one pass then its not whats expected right?
|
Thank you @ozer550 for good feedback - I pushed updates. It's based on
https://octokit.github.io/rest.js/v20/#pagination Also tested real quickly in my environment and haven't noticed any issues. |
2 participants
Summary
Disclosure: I was assisted by copilot - reviewed and adjusted all changes.
Reviewer guidance
Code review should be sufficient. I tested that it works as expected in my test organization and Slack, and after merging we can observe in production.