Random fixes for Mirality to try#756
Open
Nightenom wants to merge 2 commits intofeature/entity-handlers121from
Open
Random fixes for Mirality to try#756Nightenom wants to merge 2 commits intofeature/entity-handlers121from
Nightenom wants to merge 2 commits intofeature/entity-handlers121from
Conversation
Member
Nightenom
commented
Jun 8, 2025
Nightenom
commented
- gradle wrapper will disappear if you update from main
- fixes PAINting placement once and forever (?)
- correctly process entity content in neo caps
- reformat handleEntitySpawn to not have 16565179 tabs
Raycoms
reviewed
Jun 8, 2025
| public List<ItemStack> getRequiredItems(final Entity entity) | ||
| { | ||
| final List<ItemStack> request = new ArrayList<>(IEntityHandler.super.getRequiredItems(entity)); | ||
| request.addAll(((ContainerEntity) entity).getItemStacks()); |
Contributor
There was a problem hiding this comment.
Yeah, that makes no sense to me; collecting those items is kind of the whole point.
Member
Author
There was a problem hiding this comment.
It's done by default method, that does handle that uses the itemhandler extract method
Raycoms
reviewed
Jun 8, 2025
| { | ||
| case DENY: | ||
| continue nextEntity; | ||
| case PASS: |
Contributor
There was a problem hiding this comment.
Are you sure thr logic here is correct ?
Member
Author
There was a problem hiding this comment.
This is just random refactor, I'm kinda sure it's correct, just java and nested for loops, we want to switch to normal registry stuff here, and extend it with findHandlerFor(T value) which will return proper instance - to avoid having the search stuff everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.