Open
Conversation
(cherry picked from commit bddb781)
Raycoms
reviewed
Jan 15, 2026
| } | ||
| } | ||
| else if (requiredItems == null) | ||
| if (!handler.isCreative() && !handler.hasRequiredItems(requiredItems)) |
Contributor
There was a problem hiding this comment.
No simulate flag check here?
Raycoms
reviewed
Jan 15, 2026
| final List<? extends Entity> list = entity.level().getEntitiesOfClass(entity.getClass(), AABB.unitCubeFromLowerCorner(posInWorld)); | ||
| for (Entity worldEntity : list) | ||
| { | ||
| if (worldEntity.position().equals(posInWorld)) |
Contributor
There was a problem hiding this comment.
I'd like to add a check here too where we make sure the content is the same too. We should test with itemframes with upgrading contents then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Testing
Review please (do not port)