Merged
Conversation
RandyBarry
reviewed
Feb 5, 2026
Collaborator
RandyBarry
left a comment
RandyBarry
left a comment
There was a problem hiding this comment.
This looks okay to me. The one question I have relates to the test data for the _ignore_base.yml file. The first column has "russian" instead of "_ignore_base". Does that matter? The test is for the ignore base.
Collaborator
Author
|
I had to switch to Russian because I can't run the test on a table that is not in the index. Plus, without a complete mapping of the Roman alphabet to a different script, the transliteration would just pass all the text through, so it would give you false positives.
I guess choosing Cyrillic or another script doesn't matter if the test is only for the ignore rules, but we can change it if you prefer.
…On February 5, 2026 8:45:49 AM EST, "Randall K. Barry" ***@***.***> wrote:
@RandyBarry commented on this pull request.
This looks okay to me. The one question I have relates to the test data for the _ignore_base.yml file. The first column has "russian" instead of "_ignore_base". Does that matter? The test is for the ignore base.
--
Reply to this email directly or view it on GitHub:
#283 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
RandyBarry
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.