Open
Conversation
Updated the 'expires_at' field to reflect Unix timestamp in seconds instead of milliseconds and adjusted the signing process to use BigInt for 'expires_at'.
dimast-x
reviewed
Dec 1, 2025
| ```typescript | ||
| { | ||
| types: { | ||
| EIP712Domain: [ |
Collaborator
There was a problem hiding this comment.
@philanton @nksazonov idea for future releases: if we include <application_name> in EIP712Domain instead of domain:, then this app name would be shown in metamask header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the off-chain authentication documentation to clarify the handling of session key expiration and EIP-712 signature creation. The most important changes are grouped below:
Session Key Expiration Format
expires_atfield in the session key policy to require a 10-digit Unix timestamp in seconds, not milliseconds, and clarified that it must match the EIP-712uint64type.EIP-712 Signature Structure and Example
EIP712Domaintype from the signature example, simplifying the domain to only include thenamefield.expires_atas a BigInt in seconds and clarified the format forallowances.viemfor signing EIP-712 typed data, specifying the domain, types, and message fields, and emphasizing the need forexpires_atto be a BigInt foruint64.Updated the 'expires_at' field to reflect Unix timestamp in seconds instead of milliseconds and adjusted the signing process to use BigInt for 'expires_at'.