Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Feb 3, 2026

Note

Medium Risk
This is a cross-cutting type/contract change affecting data delivery and store initialization paths; mistakes could impact persistence decisions or readiness signaling even though the behavioral change is small and well-covered by tests.

Overview
ChangeSet.selector is now non-optional, standardizing on always carrying a Selector (using Selector.no_selector() when absent) and removing None checks across FDv2 code paths.

Initializer/polling and FDv2 readiness/persistence logic now keys solely off selector.is_defined() (e.g., when deciding Basis.persist and when to set the ready event), and store internals (_set_basis/_apply_delta) accept a required Selector. Tests were updated accordingly to assert selector.is_defined() rather than non-nullness.

Written by Cursor Bugbot for commit 892cb78. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey requested a review from a team as a code owner February 3, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants