feat: Update ChangeSet to always require a Selector #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
This is a cross-cutting type/contract change affecting data delivery and store initialization paths; mistakes could impact persistence decisions or readiness signaling even though the behavioral change is small and well-covered by tests.
Overview
ChangeSet.selectoris now non-optional, standardizing on always carrying aSelector(usingSelector.no_selector()when absent) and removingNonechecks across FDv2 code paths.Initializer/polling and FDv2 readiness/persistence logic now keys solely off
selector.is_defined()(e.g., when decidingBasis.persistand when to set the ready event), and store internals (_set_basis/_apply_delta) accept a requiredSelector. Tests were updated accordingly to assertselector.is_defined()rather than non-nullness.Written by Cursor Bugbot for commit 892cb78. This will update automatically on new commits. Configure here.