fix: Update DataSystemConfig to accept list of synchronizers #404
+200
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-1777/sync-list
branch
from
e1a1a0e to
8da2666
Compare
jsonbailey
approved these changes
Feb 2, 2026
Contributor
jsonbailey
left a comment
jsonbailey
left a comment
There was a problem hiding this comment.
I added a suggestion but don't consider it a blocker.
ldclient/impl/datasystem/fdv2.py
Outdated
| condition_func: Callable[[DataSourceStatus], bool] | ||
| ) -> tuple[bool, bool]: | ||
| condition_func: Callable[[DataSourceStatus], ConditionDirective] | ||
| ) -> tuple[bool, bool, ConditionDirective]: |
Contributor
There was a problem hiding this comment.
In Ruby I ended up collapsing this down to a single result, essentially adding the remove sync and fallback as options of the Conditional Directive. From my understanding they are all independent of each other. If you have fallback, you don't care about the other two, if you have remove sync, you don't care about the conditional directive, so there isn't a need to have all three returned.
keelerm84
force-pushed
the
mk/sdk-1777/sync-list
branch
from
c62e0c3 to
9e2c297
Compare
keelerm84
force-pushed
the
mk/sdk-1777/sync-list
branch
from
9e2c297 to
697b0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes core data-synchronization failover logic (including FDv1 fallback) and alters config shape/API, which can affect initialization and runtime update behavior across environments.
Overview
Updates the experimental data system configuration to use an ordered list of synchronizers rather than
primary_synchronizer/secondary_synchronizer, and updates the builder API (ConfigBuilder.synchronizers(*builders)) to require at least one synchronizer.Refactors the FDv2 runtime to iterate through any number of synchronizers with generalized fallback/recovery behavior (including permanent removal on failure and optional switch to the FDv1 fallback synchronizer), and updates contract-test parsing plus unit tests to match the new list-based configuration.
CI contract tests are bumped to
v3.0.0-alpha.3and YAML quoting is normalized for boolean-like inputs.Written by Cursor Bugbot for commit 697b0c2. This will update automatically on new commits. Configure here.