Skip to content

fix: Mark copy_with_new_sdk_key method as deprecated #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsonbailey wants to merge 6 commits into
base: main
Choose a base branch
from
+4 −0
Open

fix: Mark copy_with_new_sdk_key method as deprecated #353

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2eb75ff
fix: Add missing config values to copy operation
jsonbailey Sep 29, 2025
296d45f
fix lint issue
jsonbailey Sep 29, 2025
f31b59d
add deprecation instead of updating function
jsonbailey Feb 4, 2026
d859094
Merge branch 'main' into jb/enable-full-config-copy
jsonbailey Feb 4, 2026
9016e65
fix lint issue
jsonbailey Feb 4, 2026
09cec6d
show where the developer is calling the deprecated function from
jsonbailey Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ldclient/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
Note that the same class can also be imported from the ``ldclient.client`` submodule.
"""

import warnings
from dataclasses import dataclass
from threading import Event
from typing import Callable, List, Optional, Protocol, Set, TypeVar
Expand Down Expand Up @@ -357,8 +358,11 @@ def copy_with_new_sdk_key(self, new_sdk_key: str) -> 'Config':
"""Returns a new ``Config`` instance that is the same as this one, except for having a different SDK key.
The key will not be updated if the provided key contains invalid characters.

DEPRECATED: This method is deprecated and will be removed in a future version.

:param new_sdk_key: the new SDK key
"""
warnings.warn("copy_with_new_sdk_key is deprecated and will be removed in a future version", DeprecationWarning, stacklevel=2)
return Config(
sdk_key=new_sdk_key,
base_uri=self.__base_uri,
Expand Down