feat: Move iterable async queue to internal. #125
Merged
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...red/internal/src/main/java/com/launchdarkly/sdk/internal/collections/IterableAsyncQueue.java
Show resolved
Hide resolved
tanderson-ld
approved these changes
Feb 3, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Feb 3, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Feb 3, 2026
🤖 I have created a release *beep* *boop* --- ## [1.7.0](launchdarkly-java-sdk-internal-1.6.1...launchdarkly-java-sdk-internal-1.7.0) (2026-02-03) ### Features * Move iterable async queue to internal. ([#125](#125)) ([971f4b3](971f4b3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Release bookkeeping only (version/changelog updates) with no functional code changes in this diff. > > **Overview** > Prepares the `lib/shared/internal` `1.7.0` release by bumping the version in `.release-please-manifest.json` and `lib/shared/internal/gradle.properties`. > > Updates `lib/shared/internal/CHANGELOG.md` with the `1.7.0` entry noting the feature: moving the iterable async queue into the internal module. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 83c9ec3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
Feb 3, 2026
🤖 I have created a release *beep* *boop* --- ## [2.3.0](launchdarkly-java-sdk-common-2.2.1...launchdarkly-java-sdk-common-2.3.0) (2026-02-03) ### Features * Move iterable async queue to internal. ([#125](#125)) ([971f4b3](971f4b3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Release bookkeeping only (version/changelog updates) with no functional code changes in this diff. > > **Overview** > Publishes `lib/shared/common` version `2.3.0` by updating the release manifest and the module’s `gradle.properties` version. > > Updates `CHANGELOG.md` with the `2.3.0` release notes, highlighting the feature to move the iterable async queue into the internal module. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4d007b8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IterableAsyncQueue was originally in common, but we've decided it doesn't need to be exposed, so I am moving it to internal. Technically this is breaking, but we have not done a release of an SDK that uses the affected version.
Note
Medium Risk
This is an API/package move that can break any downstream code importing
IterableAsyncQueue, but the functional behavior change is minimal and limited to internal utility code.Overview
Moves
IterableAsyncQueuefrom the publiccom.launchdarkly.sdk.collectionsarea intocom.launchdarkly.sdk.internal.collections, making it explicitly internal rather than part of the supported API surface.Updates the class and its test to the new package, adds
package-info.javadocs for the new internal package/tests, and removes the oldpackage-info.javafiles fromshared/common.Written by Cursor Bugbot for commit 869e8a6. This will update automatically on new commits. Configure here.