chore: adds TestDataV2 to implement Synchronizer #124
+717
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestData.java
Outdated
Show resolved
Hide resolved
tanderson-ld
commented
Feb 2, 2026
| * @param condition condition to poll; when it returns true, this method returns | ||
| * @throws InterruptedException if the current thread is interrupted while waiting | ||
| * @throws AssertionError if the condition does not become true before the timeout | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
For reviewers: Not sure if these helpers are really warranted, but it seems to make usability better.
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestDataV2.java
Show resolved
Hide resolved
tanderson-ld
changed the title
lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/integrations/TestDataV2Test.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestDataV2.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestData.java
Show resolved
Hide resolved
kinyoklion
reviewed
Feb 3, 2026
| case INITIALIZING: | ||
| default: | ||
| // VALID and INITIALIZING do not map to FDv2 status events (same as DataSourceSynchronizerAdapter) | ||
| statusResult = null; |
Member
There was a problem hiding this comment.
For valid do we need to have a "none" changeset push?
kinyoklion
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Note
Medium Risk
Introduces a new FDv2 synchronizer and queues/async delivery behavior; while test-focused, correctness of change set ordering/versioning can affect client initialization and update semantics in tests.
Overview
Adds
TestDataV2, a new in-memory, dynamically updatable test data provider that implements the FDv2SynchronizerAPI, emitting an initial fullChangeSetfollowed by incremental partial change sets forupdate()/delete(), and supporting simulated status events plus anawaitPropagationhelper.Refactors
TestData.FlagBuilderto be reusable byTestDataV2(package-visible constructors and full copy of sampling/migration fields), and tightensTestDataTestexpectations around flag versioning; adds comprehensiveTestDataV2Testcoverage for initialization, updates, deletes, and basic flag config behaviors.Written by Cursor Bugbot for commit 818327a. This will update automatically on new commits. Configure here.