chore: Add file data source support for FDv2. #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/sdk-1562/fdv2-file-data-source
branch
from
e613d7c to
e7ada4d
Compare
kinyoklion
force-pushed
the
rlamb/sdk-1562/fdv2-file-data-source
branch
from
e7ada4d to
1a548dd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceImpl.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceImpl.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBase.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBase.java
Show resolved
Hide resolved
...sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java
Outdated
Show resolved
Hide resolved
...sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileSynchronizer.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileSynchronizer.java
Outdated
Show resolved
Hide resolved
Member
Author
|
bugbot review |
...sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBase.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileData.java
Outdated
Show resolved
Hide resolved
tanderson-ld
reviewed
Feb 2, 2026
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBase.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileSynchronizer.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileSynchronizer.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBase.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileData.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileData.java
Show resolved
Hide resolved
tanderson-ld
approved these changes
Feb 2, 2026
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core file data loading/watching and persistence semantics, and changes threading/update flow by routing legacy
DataSourcebehavior through the new FDv2FileSynchronizer. Errors or edge cases could affect startup initialization and file auto-update behavior.Overview
Adds FDv2 support for file-based flag data by introducing
FileData.initializer()(one-shot load) andFileData.synchronizer()(streaming + optional file watching) that emitFDv2SourceResultchange sets/statuses.Refactors the legacy
FileDataSourceImplto delegate all loading/watching to the newFileSynchronizer, centralizes parsing/loading logic in a sharedFileDataSourceBase, and introduces a newshouldPersistoption (legacydataSource()defaults to persisting for compatibility; FDv2 initializer/synchronizer default to not persisting). Also upgradeslaunchdarkly-java-sdk-common/launchdarkly-java-sdk-internaland switchesIterableAsyncQueueusage to the internal library implementation, removing the local class/tests and adding new FDv2 file integration tests.Written by Cursor Bugbot for commit 22aefdd. This will update automatically on new commits. Configure here.