Merged
Conversation
Swapped out an inactive library for a more actively maintained one. Also, updated it to use Draft 7, which is what the official implementation uses. See: https://github.com/openai/openai-node/blob/1a3850112451e81840840c960bf6925753d4fac3/src/lib/jsonschema.ts#L51
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from the deprecated Scala-based JSON schema generator to a modern Java library, removing the Scala dependency and updating to JSON Schema Draft 7 for better OpenAI compatibility.
Key changes:
- Replace mbknor-jackson-jsonschema with victools/jsonschema-generator for active maintenance and Draft 7 support
- Remove Scala dependency by switching to pure Java implementation
- Update Gradle wrapper version to 8.11.1
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ChatFunctionParametersSerializer.java | Replace deprecated JSON schema generator with victools implementation |
| service/build.gradle | Update dependencies to use new JSON schema libraries |
| gradle/wrapper/gradle-wrapper.properties | Upgrade Gradle wrapper version |
| gradle/libs.versions.toml | Add new library versions and remove old Scala dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Konboi
approved these changes
Sep 3, 2025
Collaborator
Konboi
left a comment
There was a problem hiding this comment.
CI failed due to LAUNCHABLE_TOKEN issue.
Let's check it after merge to the main
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the Scala dependency from the project by replacing mbknor-jackson-jsonschema_2.12 with victools/jsonschema-generator, a modern, actively maintained JSON Schema
generator.
Background
Old Library (mbknor-jackson-jsonschema):
New Library (victools/jsonschema-generator):
OpenAI API Compatibility
The new implementation uses JSON Schema Draft 7, which is officially supported by OpenAI:
https://github.com/openai/openai-node/blob/1a3850112451e81840840c960bf6925753d4fac3/src/lib/jsonschema.ts#L52