Fix: Tracer origin going offscreen#205
Closed
KMatias123 wants to merge 1 commit intolambda-client:1.21.11from
Closed
Fix: Tracer origin going offscreen#205KMatias123 wants to merge 1 commit intolambda-client:1.21.11from
KMatias123 wants to merge 1 commit intolambda-client:1.21.11from
Conversation
Collaborator
|
This would be a temporary fix as constructor plans to add 2d tracers |
Collaborator
|
This pr is probably superseded by #230. I'll close it and you can open it back in case this is still an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to sprint with view bobbing on and tracers in the crosshair mode the center where they all "point" will move around due to view bobbing. This is annoying. This commit fixes it in a way that just moves the "start of the tracers" away from the camera so the movement is not as noticeable. In the future it can also be fixed by completely negating the movement from the
camera.horizontalPlane.This is the kotlin code for calculating the bobbing if someone wants to calculate the bobbing and implement a better solution.
I just put this here cuz I don't want anyone else to have to be without tracers :3