Fix: Prevent freecam from interfering with baritone rotation#183
Closed
FaxHack wants to merge 4 commits intolambda-client:1.21.5from
Closed
Fix: Prevent freecam from interfering with baritone rotation#183FaxHack wants to merge 4 commits intolambda-client:1.21.5from
FaxHack wants to merge 4 commits intolambda-client:1.21.5from
Conversation
Fixes lambda-client#169 When baritone is active, freecam's rotation handling was interfering with baritone's ability to control player rotation. Added check to skip rotation handling in freecam when BaritoneManager.isActive is true.
Collaborator
|
@beanbag44 can you take a look also ? |
Member
|
this seems to be a larger issue with rotations not properly being overridden by baritone. We can merge this for now, but must keep in mind the larger problem as this isn't a full fix. Thoughts @emyfops ? |
Collaborator
Id rather keep this open while we figure out how to keep track of issues |
Member
|
This seems to have been fixed in commit 94a8f3c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169
Description
When baritone is active, freecam's rotation handling was interfering with baritone's ability to control player rotation, preventing baritone from turning or walking in a straight line when freecam's "rotate to target" setting was enabled.