Merged
Conversation
… into feature/tests
There was a problem hiding this comment.
Pull Request Overview
This PR introduces extensive unit tests for various mathematical, collection, and task-related utilities, while also refactoring some function and variable names for consistency across the codebase. Key changes include:
- Addition of comprehensive test suites for vector math, range functions, and collection utilities.
- Renaming of several methods (e.g. from “mod” to “remainder” and “setMaxSize” to “setSizeLimit”) to improve clarity.
- Minor refactorings in task and network modules to enhance state management and integration with the testing pipeline.
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/src/test/kotlin/* | New test classes covering Vec3d/Vec2d operations, VarIntIterator, Task handling, ranges, and collection utilities. |
| common/src/main/kotlin/com/lambda/util/* | Renaming of functions and properties for improved clarity and consistency (e.g., mod → remainder, setMaxSize → setSizeLimit). |
| .github/workflows/build.yml | Adjustments to the build workflow and branch filters. |
Files not reviewed (2)
- common/build.gradle.kts: Language not supported
- gradle.properties: Language not supported
Comments suppressed due to low confidence (2)
common/src/main/kotlin/com/lambda/task/Task.kt:41
- [nitpick] Changing both 'subTasks' and 'state' from private to public may expose internal task state to external modification. Consider retaining encapsulation unless there is a deliberate need to modify these properties externally.
val subTasks = mutableListOf<Task<*>>()
var state = State.INIT
common/src/main/kotlin/com/lambda/util/VarIntIterator.kt:36
- [nitpick] The use of the variable 'size' as a counter for groups read is slightly ambiguous. Renaming it to 'groupCount' (or a similar name) would improve clarity.
value = value or ((b and SEGMENT_BIT) shl (size++ * 7))
has issues with mocking logging ingame thats why some tests are disabled for now
65878db to
fc78398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x