Make TimeSync a Unity Singleton #67
Open
LiamOverett-AMRC wants to merge 3 commits intolabstreaminglayer:masterfrom
Open
Make TimeSync a Unity Singleton #67LiamOverett-AMRC wants to merge 3 commits intolabstreaminglayer:masterfrom
LiamOverett-AMRC wants to merge 3 commits intolabstreaminglayer:masterfrom
Conversation
It also has user configurable option to make it non-destroyable between scene changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed how
TimeSyncbehaves so only one instance of that object can exist in a scene at any given time. This fits with the "one source of truth" for timestamps across Unity projects. Also gave the Unity programmer the option to make theTimeSyncobject non-destroyable between scene changes.Changes:
TimeSyncto be a 'true' Unity singleton that will destroy itself if other instances of that object already exist in the sceneTimeSyncobject non-destroyable between scene changesBaseOutletto reference the updateTimeSyncsingleton