Open
Conversation
SvenDS
approved these changes
Jul 30, 2018
SvenDS
left a comment
SvenDS
left a comment
There was a problem hiding this comment.
Tested with succes Teensy 3.2 + W850io
|
https://github.com/hadleyrich/ArduinoWebsocketClient has added the headers for Sec-Websocket-Key. Tested with a Node server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These simple changes allow for compatibility with most 32 bit boards.
In the string table, pointers need to be read with pgm_read_ptr(), since pgm_read_word() is fixed at 16 bits.
In monitor(), on systems where char is unsigned the "endReached" condition can never be true. The simple solution is to use "int" which matches the return type of _client.read() and convert to char as needed.
The example also needs to use String() to properly print the result.
I know this is a very old library that's probably not maintained anymore, but hopefully these simple changes will help anyone trying to use modern 32 bit boards.