Added minimum _test.go files for files that does not have tests.#650
Merged
ToreMerkely merged 1 commit intomainfrom Feb 3, 2026
Merged
Added minimum _test.go files for files that does not have tests.#650ToreMerkely merged 1 commit intomainfrom
ToreMerkely merged 1 commit intomainfrom
Conversation
We use the tool cover for coverage, but if there is no _test.go file, then Go use the tool covdata. At the same time, they removed covdata as a precompiled binary in the distribution. This made the coverage calculation fail for some of us. As described in this discussion golang/go#75031 there is an other option to fix this by modifying the GOTOOLCHAIN variable, but that is too much magic for me and could be very hard to debug for the next person who stumbles over this.
gsavage
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the tool cover for coverage, but if there is no _test.go file,
then Go use the tool covdata. At the same time, they removed covdata
as a precompiled binary in the distribution. This made the coverage
calculation fail for some of us.
As described in this discussion
golang/go#75031
there is an other option to fix this by modifying the
GOTOOLCHAIN variable, but that is too much magic for me and
could be very hard to debug for the next person who stumbles
over this.