Add --flow-tag flag to list trails command#648
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a --flow-tag flag to the list trails command, enabling users to filter trails by flow tags. The change allows listing trails across all flows that are tagged with a specific key-value pair.
Changes:
- Added
--flow-tagflag to filter trails by flow tags in key=value format - Implemented validation to ensure the flow-tag format is correct
- Added comprehensive test coverage for the new flag functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/kosli/listTrails.go | Added flow-tag flag, validation logic, and URL parameter construction |
| cmd/kosli/root.go | Added flag description constant for the new flow-tag flag |
| cmd/kosli/listTrails_test.go | Added test cases for flow-tag filtering including valid tags, non-existing tags, and invalid format |
| cmd/kosli/testHelpers.go | Added TagFlow helper function to support testing flow tagging |
| cmd/kosli/list.go | Removed duplicate validateForListTrails function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sami-alajrami
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the
flow-tagflag to thelist trailscommand.