Change request_iteration_count to use a GET request#45
Open
TillerBurr wants to merge 2 commits intokonomae:masterfrom
Open
Change request_iteration_count to use a GET request#45TillerBurr wants to merge 2 commits intokonomae:masterfrom
request_iteration_count to use a GET request#45TillerBurr wants to merge 2 commits intokonomae:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 10 10
Lines 385 385
=======================================
Hits 280 280
Misses 105 105
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix suggested in #44 (comment). It was tested with my personal account and it works well.
Whilst testing, I also found that changing the request to
/iterations.phpto aGETis not enough. TheUser-Agentin the header must also be changed frompython/requeststo something else. It doesn't matter what it's changed to. For this repo, this was already fixed in commit fad6e0c.As noted in lastpass/lastpass-cli#604, one workaround is to change the iterations to 100100 by performing the following:
Closes #44