Merged
Conversation
mhoemmen
force-pushed
the
LWG4302
branch
2 times, most recently
from
1e6aa7c to
4d49fad
Compare
* Remove vector_sum_of_squares from the public interface. This implements the proposed fix for LWG4302, that is now in the Working Draft for C++26. * Fix Issue kokkos#320. If the "init" argument of vector_two_norm is nonzero, return the square root of the ((square of init) and the (sum of squares of the absolute values of the elements of x)).
Contributor
Author
|
I've actually implemented a proposed fix for an LWG issue that I just filed, to use the square of the absolute value of |
youyu3
approved these changes
Jan 29, 2026
Contributor
youyu3
left a comment
youyu3
left a comment
There was a problem hiding this comment.
The implementation looks good to me. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
vector_sum_of_squaresfrom the public interface. This implements the proposed fix for LWG4302, that is now in the Working Draft for C++26.Fix Issue [linalg] Discrepancy between [linalg.algs.blas1.nrm2] and reference implementation #320. Make
vector_two_normreturn the square root of the ((square of the absolute value ofinit) and the (sum of squares of the absolute values of the elements ofx)).