Bump k8s libs to 1.35 #3316
Open
Bump k8s libs to 1.35 #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XXL
knative-prow
bot
added
the
approved
Member
|
FYI - unit tests failed |
K8s 1.35 introduced a WatchList feature that sets SendInitialEvents=true by default. This causes reflectors to wait for a bookmark event marking the end of initial events. Fake clients don't send these bookmarks, causing tests to timeout after 10 minutes. Fix by implementing IsWatchListSemanticsUnSupported() to signal that fake clients don't support the WatchList feature, preventing the reflector from waiting indefinitely for bookmark events. Fixes test failures in webhook/psbinding, resolver, and apis/duck packages.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
I addressed it in 4785202. Can you check on this? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3316 +/- ##
==========================================
+ Coverage 74.64% 74.65% +0.01%
==========================================
Files 188 188
Lines 8207 8216 +9
==========================================
+ Hits 6126 6134 +8
- Misses 1841 1842 +1
Partials 240 240 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next knative release (1.22) will require 1.34 as the min version (see Release-Schedule). So bumping to 1.35 libs since it supports k8s 1.34 and 1.35.