Fix macOS tray toggle and Space switching #373
Merged
+225
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix primary action not hiding the tray window in accessory mode (no other windows) - Add Space detection via NSApp.windows iteration (Native.getComponentID returns 0 for Compose DialogWindow) - Move window to active Space via bringFloatingWindowToFront() instead of auto-following - Suppress focus-loss auto-hide on Space switch to prevent race condition - Use AtomicLong for thread-safe cross-thread timestamp communication - Reduce toggle/show/hide delays for snappier responsiveness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Native.getComponentIDreturning 0 on Compose DialogWindow)Changes
isFloatingWindowOnActiveSpace(),bringFloatingWindowToFront(),applySpaceBehavior()methods using NSApp.windows fallbackAtomicLongfor thread-safe timestamps, Space-aware primary action logic, focus listener suppression on Space switch, reduced timing constantsTest plan