Fix macOS window not appearing when switching Spaces #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When the tray window was visible on Space 1 and the user switched to Space 2, clicking the tray icon would attempt to hide the window (because it was marked as "visible") rather than bringing it to the current Space. This resulted in the window not appearing at all when clicking the tray icon from a different Space.
Solution
Before hiding the window on a tray icon click, check if the window has focus:
setMoveToActiveSpace()andtoFront()Test plan