Fix type error when header is not a JSON object #715
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304
force-pushed
the
fix_type_error_2_segment_token_header
branch
from
7e4fd1d to
94b8a43
Compare
Prevent TypeError when decoding tokens with non-hash headers (e.g., arrays). Fixes a TypeError where malformed tokens with array headers caused "no implicit conversion of String into Integer" error instead of raising the expected JWT::DecodeError.
304
force-pushed
the
fix_type_error_2_segment_token_header
branch
from
94b8a43 to
aaa77a6
Compare
anakinj
reviewed
Feb 3, 2026
| it 'should raise JWT::DecodeError' do | ||
| expect do | ||
| JWT.decode data[:invalid_2_segment_header_token] | ||
| end.to raise_error JWT::DecodeError |
Member
There was a problem hiding this comment.
Could we check that the error message or that a part of it is the expected message? The JWT::DecodeError could basically be any of the errors raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent TypeError when decoding tokens with non-hash headers (e.g., arrays).
Fixes a TypeError where malformed tokens with array headers caused "no implicit conversion of String into Integer" error instead of raising the expected
JWT::DecodeError.Checklist
Before the PR can be merged be sure the following are checked: