Closed
Conversation
Owner
|
Thanks for the contribution!
Does this mean you aren't interested in adding unit tests, or that you plan to add them later? :) |
Author
|
I plan to add later, unless someone does it first 😹 |
|
very needed! how can I help? |
Author
|
@giulianok for this PR to be acceptable, I am missing unit tests. You can collaborate adding the unit tests / take over / or work directly from this branch to unblock your dependent work. |
|
Looks like I might have duplicated some work :) But here is a fix with partial tests: #26 |
Author
|
Closing due inactivity and duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to special characters, fixing the bug #4.
I haven't yet added unit tests, just tested for my local usage for now.