Open
Conversation
Signed-off-by: Johny Lin <johnylin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider adding a switch control on module_adapter for Waves CTC toggling.
It is way more robust to toggle states via a switch control than a bytes control.
This commit is the practice example. It is not verified yet as my device is getting some unexpected license problems today.
On the other hand, I think it is also worth a try in advance that aligning the bytes config setting logic as https://github.com/thesofproject/sof/blob/main/src/audio/google/google_ctc_audio_processing.c#L437
That is, when a new bytes config is delivered via apply_config(), it can be deferred to the next process() routine to be taken by MaxxChrome, instead of taking it promptly.