Open
Conversation
|
Hey @johnnypaper, can you review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added 3 fixes:
Removed the rounding in the RSI calculation so the number is more precise
Fixed the hardcoded percentages, they were swapped.
Note: these numbers are the same as the calculation in case the period is not 12 or 26. I imagine these values are rounded and hardcoded for some specific use case. Maybe they can be removed and use the universal formula instead?
(lines 65-67 of lib/ruby_technical_analysis/indicators/moving_averages.rb)