feat(deps): upgrade to cachefactory 3.0.0#258
Open
Delagen wants to merge 3 commits intojmdobry:masterfrom
Open
feat(deps): upgrade to cachefactory 3.0.0#258Delagen wants to merge 3 commits intojmdobry:masterfrom
Delagen wants to merge 3 commits intojmdobry:masterfrom
Conversation
Author
|
requires jmdobry/CacheFactory#30 |
Owner
|
I guess angular-cache should be update to work with the latest versions of Angular 1.x only? |
Author
|
I removed unneded config, so it works but only with jmdobry/CacheFactory#30 Where i wrote why. |
Author
|
Any update? |
Author
|
Any news? |
|
🙏 |
|
Any news regarding this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to latest cachefactory
Main issue with angular is the difference in handling $http promises handling to access headers and other data
before 1.6.x
$http().success(data,headers).error(...).then(data)
from 1.6.x
$http().then({data,headers...})
Align introduces in 1.4.4 with http://devdocs.io/angularjs~1.5/api/ng/provider/$httpprovider#useLegacyPromiseExtensions
Update: rescan source cause it only sugar. So nothing needed in angular to config. Only jmdobry/CacheFactory#30