Open
Conversation
Based on the 'debugger' check, this checks for accidental short-circuits often used in debugging. ``` if true && something if false && something ```
Collaborator
|
oh, I missed to update readme, there is now easy way to create external plugins => https://github.com/jish/pre-commit/blob/master/lib/pre-commit/cli.rb#L31 - maybe try to make it an external plugin and we can add it to https://github.com/pre-commit-plugins/ and list it in the readme :) code itself LGTM |
|
@ideasasylum Did you ever make a plugin out of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is generally useful but I've found it very important. This checks for accidental short-circuits often used in debugging, e.g. Rails views, to force a particular state.
Statements like,
can be used when developing to force a particular condition but they're almost certainly an error if committed to Git.
I based this check & tests on the debugger check so I hope I haven't missed anything.