Add support for scad modules#82
Draft
nickdavies wants to merge 1 commit intojeff-dh:master-2.0.0-beta-devfrom
Draft
Add support for scad modules#82nickdavies wants to merge 1 commit intojeff-dh:master-2.0.0-beta-devfrom
modules#82nickdavies wants to merge 1 commit intojeff-dh:master-2.0.0-beta-devfrom
Conversation
This is useful for large models where you want to force rendering regularly and to make the output code more understandable.
Owner
|
I only had a brief look at your code. It looks really nice so far! Buuuuuuuut unfortunately......
I like the idea of integrating it into SolidPython2 itself. If you like have a look at the other implementation and adjust if necessary (does your code support parameters?) and I'd be happy to merge a result! |
Author
|
Ah I did not see that repo! I will take a look and see if this still makes sense. Currently my code doesn't support parameters, I didn't really need them so I didn't bother but I wouldn't want to regress that if you already have it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for large models where you want to force rendering regularly and to make the output code more understandable.
I did not attempt to integrate this with the variables logic in the extensions directory though as my usecase was mostly for performance and readability.