[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12262] Exclude CMAB from UserProfileService #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated decision_service.py to exclude CMAB experiments from UPS - CMAB should not use UPS for sticky bucketing due to dynamic nature - Added check: `and not experiment.cmab` in two locations 1. When looking up stored variation from UPS (line 461) 2. When saving variation decision to UPS (line 533) Test Coverage: - Added 3 comprehensive unit tests (all passing) - test_get_variation_cmab_experiment_excludes_user_profile_service_lookup - test_get_variation_cmab_experiment_excludes_user_profile_service_save - test_get_variation_non_cmab_experiment_uses_user_profile_service - All 51 tests in test_decision_service.py pass QA Summary: - Iterations: 1/5 (SUCCESS on first try) - Tests: 51/51 passed - Code Review: APPROVED (clean, minimal changes) - Files Modified: optimizely/decision_service.py, tests/test_decision_service.py Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR excludes CMAB (Contextual Multi-Armed Bandit) experiments from User Profile Service (UPS) for sticky bucketing.
Jira Ticket: FSSDK-12262
Changes
optimizely/decision_service.pyto exclude CMAB experiments from UPSand not experiment.cmabin two critical locations:Rationale
CMAB should not use UPS for sticky bucketing because:
Test Coverage
New Tests Added (3):
test_get_variation_cmab_experiment_excludes_user_profile_service_lookuptest_get_variation_cmab_experiment_excludes_user_profile_service_savetest_get_variation_non_cmab_experiment_uses_user_profile_serviceTest Results: ✅ All 51 tests pass (no regressions)
Quality Assurance
Files Modified
optimizely/decision_service.py(6 lines changed)tests/test_decision_service.py(180 lines added)🤖 Generated with Claude Code