[#502] experimental test harness using a single container by d-w-moore · Pull Request #508 · irods/python-irodsclient

d-w-moore · 2024-01-30T16:11:17Z

Automatic launch of specific test scripts in their own container.

d-w-moore · 2024-01-30T16:12:32Z

irods/test/harness/000_install-irods.Dockerfile

+RUN /root/ubuntu_irods_installer/install.sh --w="add-package-repo" 0
+RUN /root/ubuntu_irods_installer/install.sh --i=${irods_vsn} -r 4


these need to be brought local. and, they'll be replaced eventually , probably by the minimal irods install commands.

korydraughn

Please explain what this PR does?

Are there plans to leverage the consortium test hook and the testing environment?

korydraughn · 2024-01-30T17:49:55Z

irods/test/harness/000_install-irods.Dockerfile

@@ -0,0 +1,24 @@
+ARG linux_vsn="ubuntu:18.04"


18.04 is EOL.

Please bump to 20.04 or 22.04.

korydraughn · 2024-01-30T17:55:40Z

irods/test/harness/tests/repo

@@ -0,0 +1 @@
+../../../..


What is this used for?

To figure out relative paths when generating the execute line for the docker container

This no longer exists. The purpose is now fulfilled by print_repo_root_location, a script which prints the absolute path of the repo regardless the current working directory when it's launched. That absolute result is useful within docker_container_driver.sh especially when calculating the paths of things relative to that root.

Let me know if this seems an adequate explanation, and I'll resolve. But, of course, I will understand if the truth of the matter is otherwise. It was confusing to write, probably more confusing to read. The end purpose is calculating container-internal paths using those container-external paths as input, which was less trivial than I'd first imagined.

korydraughn · 2024-01-30T17:58:03Z

irods/test/harness/000_install-irods.Dockerfile

+RUN apt update
+RUN apt install -y sudo git
+WORKDIR /root
+RUN git clone http://github.com/d-w-moore/ubuntu_irods_installer


Is this temporary?
What does this offer?

A lot of this could be considered temporary. We really just need a stand_it_up equivalent tbh

We're now doing the "install and stand up" thing for the iRODS server running within each container, and with no dependencies on the ubuntu_irods_installer repo.

d-w-moore · 2024-01-30T21:35:28Z

Please explain what this PR does?

Are there plans to leverage the consortium test hook and the testing environment?

[....] I wanted to get a start on this issue and get comments in but do not believe this will be merged for the next prc release.

Seems this PR is part of the 2.0.0 milestone after all, so maybe we try to leverage those somewhere in a later release?

d-w-moore · 2024-03-08T05:24:04Z

Rebasing atop 518.m , and I may leave it that way to save time. After un-drafting, we'll decide if #518 gets its own pull request

trel · 2024-03-14T12:44:17Z

let's not mention 281 in the first part of the commit lines, we can reference it in the body if helpful/needed.

d-w-moore · 2024-03-14T14:23:13Z

let's not mention 281 in the first part of the commit lines, we can reference it in the body if helpful/needed.

Yes, will correct that.

d-w-moore · 2024-05-14T03:14:59Z

Please explain what this PR does?

Are there plans to leverage the consortium test hook and the testing environment?

Basically there are a bunch of tests which demand unique setup or otherwise unique running conditions. This PR is part of a plan to run each of those - automatically is the hope. Inclusion is the idea, preventing regression. And it's easy to set up conditions for such tests within a Dockerfile.

d-w-moore · 2025-03-14T05:26:08Z

SKIP_IINIT_FOR_PASSWORD documented (currently in 7d75ae9)

testuser universal for all containers login_auth*.py adjustments [__502] scriptdir [__502] patch for consistency in starting document SKIP_IINIT_FOR_PASSWORD "funcs" include file renamed to "test_support_functions" remove fail.sh to scripts dir

d-w-moore · 2025-09-23T11:42:32Z

Once all the conversations above are resolved, my plan is to cancel this PR and integrate the changes herein (the addition of a single-docker-container test harness that is well suited for testing via BATS scripts and other test modules requiring custom setup) into a new Pull Request dealing with the wider goal of testing PRC under Github Actions.

trel · 2025-09-23T11:56:48Z

or you can just push the changes here - so the conversation is in one place?

up to you.

of course, link back here in any new PR so the archaeologists can find it.

d-w-moore marked this pull request as draft January 30, 2024 16:11

d-w-moore commented Jan 30, 2024

View reviewed changes

korydraughn reviewed Jan 30, 2024

View reviewed changes

d-w-moore force-pushed the 502.m branch 2 times, most recently from fedbf73 to 858374b Compare March 7, 2024 11:05

d-w-moore force-pushed the 502.m branch 3 times, most recently from 8109fec to 00e9cc2 Compare March 14, 2024 12:21

d-w-moore force-pushed the 502.m branch from 56013a1 to 4a9df26 Compare March 14, 2024 14:26

d-w-moore force-pushed the 502.m branch 2 times, most recently from 2d19eac to bc07343 Compare March 24, 2024 08:36

d-w-moore force-pushed the 502.m branch 2 times, most recently from 65a4bee to a9c2d75 Compare April 5, 2024 09:04

d-w-moore mentioned this pull request Apr 16, 2024

[#519] correct regression with server_verify_mode of "none" #530

Merged

d-w-moore changed the title ~~[_502] experimental test harness using containers~~ [#502] experimental test harness using containers May 14, 2024

d-w-moore mentioned this pull request May 14, 2024

[535] Implement basic support for GenQuery2 #555

Merged

d-w-moore changed the title ~~[#502] experimental test harness using containers~~ [#502] experimental test harness using a single container Jun 14, 2024

d-w-moore force-pushed the 502.m branch from 21ce0ff to 3e40db5 Compare August 14, 2024 19:10

d-w-moore mentioned this pull request Oct 2, 2024

[#517] allow generating a pam-password based .irodsA if not pre-existing #620

Merged

d-w-moore mentioned this pull request Mar 11, 2025

Authenticate native and pam_password with iRODS 4.3+ auth framework #685

Merged

d-w-moore force-pushed the 502.m branch 2 times, most recently from 7d75ae9 to b4f6592 Compare March 15, 2025 01:23

d-w-moore added 2 commits May 8, 2025 10:21

extra time parameter to age_out_pam_password

1a6ce64

d-w-moore added 3 commits May 8, 2025 10:21

SKIP_IINIT_FOR_PASSWORD option for pam user env setup

eaa5395

add mtime_and_content

9f0286c

add tests 001 thru 009 to test params

4421f80

d-w-moore force-pushed the 502.m branch from bb9b344 to 463b5bc Compare May 8, 2025 22:48

d-w-moore added 8 commits September 23, 2025 09:51

add irods_server_version to test_support_functions

3832ff0

can now give exact filename of dockerfiles to build

cd9e1bb

firm up package defs; allow run under podman

99cf753

correct test009 name

6cf1bc7

bats tests - IRODS version macros, params

24c710e

README.txt

a455662

version-string-driven building of python interpreter builder image

63cc566

script to start server under iRODS 5

62be002

d-w-moore force-pushed the 502.m branch from b5c11a1 to 62be002 Compare September 23, 2025 14:25

		RUN /root/ubuntu_irods_installer/install.sh --w="add-package-repo" 0
		RUN /root/ubuntu_irods_installer/install.sh --i=${irods_vsn} -r 4

Conversation

d-w-moore commented Jan 30, 2024

Uh oh!

d-w-moore Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

korydraughn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d-w-moore commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

d-w-moore commented Mar 8, 2024

Uh oh!

trel commented Mar 14, 2024

Uh oh!

d-w-moore commented Mar 14, 2024

Uh oh!

d-w-moore commented May 14, 2024

Uh oh!

d-w-moore commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

d-w-moore commented Sep 23, 2025

Uh oh!

trel commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

d-w-moore Jan 30, 2024 •

edited

Loading

d-w-moore commented Jan 30, 2024 •

edited

Loading

d-w-moore commented Mar 14, 2025 •

edited

Loading