[uss_qualifier] factorize uss availability fragment#1164
Merged
BenjaminPelletier merged 6 commits intointeruss:mainfrom Sep 16, 2025
Merged
[uss_qualifier] factorize uss availability fragment#1164BenjaminPelletier merged 6 commits intointeruss:mainfrom
BenjaminPelletier merged 6 commits intointeruss:mainfrom
Conversation
RustedBones
force-pushed
the
reuse-dss-availability-framents
branch
from
5f16c88 to
778b1ac
Compare
BenjaminPelletier
approved these changes
Sep 16, 2025
Comment on lines
+353
to
+354
| availability = UssAvailabilityState.Unknown | ||
| version = "" |
Member
There was a problem hiding this comment.
I think this maintains parity with the existing implementation, but if we actually expect check.record_failed to interrupt execution below, then it seems like we expect these values never to be used. In that case, I think it would be better to return inside the try and raise a ScenarioDidNotStopError inside the except. That can be a separate-PR follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement counterpart of the DSS availability
readandupdatefragments indss/test_step_fragments.pyReuse those fragments in the
USSAvailabilitySynchronizationscenarioUpdate the
set_uss_downandset_uss_availablefragments to read state version before executing an update to prepare for #1137Move
make_dss_reportin dss package to avoid circular imports