Include hash of weights in the key of the primitive cache for aarch64 lowp gemm#341
Draft
fadara01 wants to merge 1 commit intointel:ideep_pytorchfrom
Draft
Include hash of weights in the key of the primitive cache for aarch64 lowp gemm#341fadara01 wants to merge 1 commit intointel:ideep_pytorchfrom
fadara01 wants to merge 1 commit intointel:ideep_pytorchfrom
Conversation
… lowp gemm This goes in hand with uxlfoundation/oneDNN#2194 which sets the weights as constant for Arm Compute Library (ACL) lowp gemm objects. This is a temp fix which is needed because the lowp gemm ACL object in oneDNN is now holding more state. Hence, we need to make sure that the cahce maps a layer with a specific set of weights to the oneDNN primitive storing those weights. We're currently working on the proper fix for this which involves making lowp_gemm stateless and fixed-format in ACL and oneDNN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes in hand with uxlfoundation/oneDNN#2194 which sets the weights as constant for Arm Compute Library (ACL) lowp gemm objects.
This is a temp fix which is needed because the lowp gemm ACL object in oneDNN is now holding more state. Hence, we need to make sure that the cahce maps a layer with a specific set of weights to the oneDNN primitive storing those weights.
We're currently working on the proper fix for this which involves making lowp_gemm stateless and fixed-format in ACL and oneDNN.