Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a logger parameter to multiple functions within the orchestrator and index modules to enable detailed logging of operations such as calibration, search, consolidation, point addition, and deletion. Key changes include propagating the logger argument through function calls, updating test calls to include logger parameters, and ensuring fallback behavior for logger usage is maintained.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/svs/index/vamana/dynamic_index_2.cpp | Updated test_loop to pass logger to add/delete calls |
| tests/integration/vamana/index_search.cpp | Propagated logger and introduced log verification checks |
| include/svs/orchestrators/vamana.h | Added logger parameter to orchestrator APIs |
| include/svs/orchestrators/manager.h | Updated manager interface to support logger |
| include/svs/orchestrators/dynamic_vamana.h | Added logger parameter to dynamic operations |
| ... (other files updated similarly) | Logger parameter added and propagated throughout |
Comments suppressed due to low confidence (2)
include/svs/orchestrators/vamana.h:95
- Consider updating the inline documentation for the function signature to include information about the new logger parameter and its default behavior.
const index::vamana::CalibrationParameters& calibration_parameters,
include/svs/index/vamana/dynamic_index.h:707
- It would be beneficial to document the fallback logic (using logger_ if available, otherwise logger) so that users understand how the logger is determined in this context.
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR on logging
Target:
Adding logging in
orchestrator level:
Functions to add:
experimental_calibrate
search
consolidate
add_points
delete_points/entries
index level:
compact