feat(ui-progress): migrate progress bar to new theming #2314
+88
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamlobler
requested changes
Dec 17, 2025
Collaborator
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
The full border color is missing, the whole component should have a separate borderColor:
We should add the border radius to the whole component now it seems like only the bar has a border radius:
git-nandor
approved these changes
Jan 5, 2026
matyasf
requested changes
Jan 15, 2026
Collaborator
There was a problem hiding this comment.
- rebrand and rebrand-dark are missing the border
- please put any token changes to the upgrade guide
- The second example's progress text is unreadable in dark theme, I guess this is a design issue? (you need to rebase to the latest v12 commit to see this)
joyenjoyer
force-pushed
the
INSTUI-4802-progress-bar
branch
from
4d27d3b to
3112d15
Compare
joyenjoyer
force-pushed
the
INSTUI-4802-progress-bar
branch
from
3112d15 to
608f361
Compare
Contributor
Author
|
@adamlobler changed the values of the |
matyasf
approved these changes
Feb 3, 2026
adamlobler
requested changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes InstUI-4802
Test:
ProgressBarcomponent