This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Allow documents to be loaded locally for Knowledge Injection#69
Open
murthyrudra wants to merge 1 commit intoinstructlab:mainfrom
Open
Allow documents to be loaded locally for Knowledge Injection#69murthyrudra wants to merge 1 commit intoinstructlab:mainfrom
murthyrudra wants to merge 1 commit intoinstructlab:mainfrom
Conversation
Signed-off-by: Rudra <rmurthyv@in.ibm.com>
This was referenced Nov 15, 2024
bjhargrave
suggested changes
Nov 15, 2024
Contributor
bjhargrave
left a comment
There was a problem hiding this comment.
This change would also be a move to v4 since it is adding a new feature and anyone using the new feature would need to be able to specify their dependence by declaring the document is v4.
Has such a change like this been discussed and agreed in a design doc for the whole project since many parts of instructlab will need coordinated changes?
| @@ -76,28 +76,32 @@ | |||
| "description": "The knowledge documents.", | |||
| "type": "object", | |||
| "required": [ | |||
Contributor
There was a problem hiding this comment.
I don't think you have properly specified the oneOf choice here correctly in JSON schema. It is one of either repo+commit or folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the
knowledge.jsoninv3schema to include an optional field namedfolderwhich points to the local filesystem. For this update, I had to make the fieldsrepoandcommitoptional instead ofrequired.The users can specify the folder as follows in the
qna.yamlfile in the taxonomy