fix (SelectSeasson.tsx): Adjusting minSeasons champions league.#151
Open
LucasBerce71 wants to merge 2 commits intoinker:masterfrom
Open
fix (SelectSeasson.tsx): Adjusting minSeasons champions league.#151LucasBerce71 wants to merge 2 commits intoinker:masterfrom
LucasBerce71 wants to merge 2 commits intoinker:masterfrom
Conversation
Hello, when selecting the elimination round session below the 2002 season, the application crashed because there was no data for the 2000/2001, 2001/2002 seasons, even with the minSeasons property having the 2000 season as its value. So to solve the problem quickly, while the .json files of the respective seasons are not added, I changed the value of the minSeason property to 2002, which is the season where the .json referring to the year is. I hope I have helped in some way, and I am available for any questions. Thanks :)
I would like to keep my previous description of this same pull request, but in that PR I was wrong in a detail, the correct value of minSeasson must be 2003, because the existing .json files in the application are from. 2003/2004 season. Thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, when selecting the elimination round session below the 2002 season, the application crashed because there was no data for the 2000/2001, 2001/2002 seasons, even with the minSeasons property having the 2000 season as its value.
So to solve the problem quickly, while the .json files of the respective seasons are not added, I changed the value of the minSeason property to 2002, which is the season where the .json referring to the year is.
I hope I have helped in some way, and I am available for any questions. Thanks :)