fix: impl Tx for the recently introduced blob sidecar enum variant#137
fix: impl Tx for the recently introduced blob sidecar enum variant#137prestwich merged 2 commits intoinit4tech:mainfrom
Conversation
src/fill/alloy.rs
Outdated
| impl Tx for Recovered<&EthereumTxEnvelope<TxEip4844WithSidecar<BlobTransactionSidecarVariant>>> { | ||
| fn fill_tx_env(&self, tx_env: &mut TxEnv) { | ||
| match self.inner() { | ||
| EthereumTxEnvelope::Legacy(t) => { | ||
| Recovered::new_unchecked(t, self.signer()).fill_tx_env(tx_env) | ||
| } | ||
| EthereumTxEnvelope::Eip2930(t) => { | ||
| Recovered::new_unchecked(t, self.signer()).fill_tx_env(tx_env) | ||
| } | ||
| EthereumTxEnvelope::Eip1559(t) => { | ||
| Recovered::new_unchecked(t, self.signer()).fill_tx_env(tx_env) | ||
| } | ||
| EthereumTxEnvelope::Eip4844(t) => { | ||
| Recovered::new_unchecked(t, self.signer()).fill_tx_env(tx_env) | ||
| } | ||
| EthereumTxEnvelope::Eip7702(t) => { | ||
| Recovered::new_unchecked(t, self.signer()).fill_tx_env(tx_env) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
this is also something that can be made generic, should i?
There was a problem hiding this comment.
i'm on the fence about making these generic, as there's currently no trait bound to limit the typevar to something that's valid in context afaik
I suppose it won't cause any issues to go more generic, and it does DRY the code. let's make this generic as well
There was a problem hiding this comment.
there was a problem with generics because of missing trait bound as you point out. but i added a macro instead.
|
thank you! alloy introduced a breaking change in as a workaround, in your project you can downgrade all alloy packages to |
|
this will be released in trevm@0.31.4 shortly |
2 participants
There were compile errors when i tried to use this library.