Skip to content

chore: update to match changed dependencies#216

Merged
Fraser999 merged 2 commits intomainfrom
fraser/eng-1819/update
Feb 7, 2026
Merged

chore: update to match changed dependencies#216
Fraser999 merged 2 commits intomainfrom
fraser/eng-1819/update

Conversation

@Fraser999
Copy link
Contributor

No description provided.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Fraser999 Fraser999 marked this pull request as ready for review February 6, 2026 22:43
#![cfg_attr(not(test), warn(unused_crate_dependencies))]
#![deny(unused_must_use, rust_2018_idioms)]
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
#![recursion_limit = "256"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, we get:

error: queries overflow the depth limit!
  |
  = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`builder`)
  = note: query depth increased by 130 when computing layout of `{async fn body of config::<impl at src/config.rs:173:1: 173:19>::connect_builder_signer()}`

It seems reasonable to just take the compiler's advice here. We're only just over the default limit of 128, and presumably that happened due a slight increase in complexity of type nesting in one of the updated deps.

.gitignore Outdated
.vscode/launch.json No newline at end of file
.vscode/launch.json

.claude/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add .claude/ to the gitignore since we're adding skills for individual repos instead of centralizing them.

Copy link
Contributor Author

@Fraser999 Fraser999 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's handy to have this ignored since claude code will create .claude/settings.local.json if you do something like give it permission to always do a web search while working in that repo. I guess we should be more specific and just ignore the .local.json file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 3e11601.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that's a better pattern for this.

Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.gitignore Outdated
.vscode/launch.json No newline at end of file
.vscode/launch.json

.claude/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that's a better pattern for this.

@Fraser999 Fraser999 merged commit 269318d into main Feb 7, 2026
6 checks passed
@Fraser999 Fraser999 deleted the fraser/eng-1819/update branch February 7, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants