feat(submit): pylon blob preloading integration#215
Draft
Conversation
prestwich
requested changes
Feb 5, 2026
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
i think the task is too heavy. we just need a fire-and-forget dispatch in the flashbots spawned future. I also think we're duplicating the sidecar and passing it around too much?
src/tasks/submit/flashbots.rs
Outdated
| /// Builds a MEV bundle from a signed transaction envelope and simulation result. | ||
| fn build_bundle(&self, envelope: &TxEnvelope, sim_result: &SimResult) -> EthSendBundle { | ||
| let tx_bytes: Bytes = envelope.encoded_2718().into(); | ||
| let txs = self.build_bundle_body(sim_result, tx_bytes); |
Member
There was a problem hiding this comment.
refactor while we're here: the build_bundle_body method doesn't use self. which implies that it is on the wrong type. what type should it be on?
Member
Author
There was a problem hiding this comment.
this is something i was kinda pondering before, along with sidecar things. both building the sidecar, and the bundle body, could live on SimResult? it doesn't really change once returned, so it could just be memoized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.