Skip to content

chore: update FromEnvErr::ParseError#117

Merged
Fraser999 merged 1 commit intomainfrom
fraser/eng-1819/update-error
Feb 6, 2026
Merged

chore: update FromEnvErr::ParseError#117
Fraser999 merged 1 commit intomainfrom
fraser/eng-1819/update-error

Conversation

@Fraser999
Copy link
Contributor

@Fraser999 Fraser999 commented Feb 6, 2026

This updates the FromEnvErr::ParseError variant in two ways:

  • adds a String field to hold the name of the relevant env var - useful for debugging output
  • changes the wrapped error from a generic type to a Box<dyn Error> which reduces a lot of boilerplate

The PR also includes version bumps for the two crates.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Fraser999 Fraser999 changed the title update FromEnvErr::ParseError chore: update FromEnvErr::ParseError Feb 6, 2026
@Fraser999 Fraser999 marked this pull request as ready for review February 6, 2026 16:47
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like deleting code from proc macro

@Fraser999 Fraser999 merged commit b319b35 into main Feb 6, 2026
7 checks passed
@Fraser999 Fraser999 deleted the fraser/eng-1819/update-error branch February 6, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants