fix bug: mapping from msgpack response to int, Integer, long, Long types works fine#671
Open
chabapok wants to merge 1 commit intoinfluxdata:masterfrom
Open
fix bug: mapping from msgpack response to int, Integer, long, Long types works fine#671chabapok wants to merge 1 commit intoinfluxdata:masterfrom
chabapok wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
Collaborator
|
Nice catch, one small formatting nit: |
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=========================================
Coverage 88.18% 88.18%
Complexity 722 722
=========================================
Files 69 69
Lines 2513 2513
Branches 268 268
=========================================
Hits 2216 2216
Misses 208 208
Partials 89 89
Continue to review full report at Codecov.
|
Contributor
|
I'm reviewing this PR. Please, do not merge. |
|
Did anything ever happen with this one? |
|
What is a progress on this? |
|
Hi @fmachado, any update on this PR? |
|
I think he stopped working on this a long time ago. That's left a lot of PRs unmerged and most have likely gone to the influxdb-client-java repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the unit tests of the
InfluxDBResultMapperis based on the assumption that all numbers in response from influxd isDouble. It will be ok withJSON. Butmsgpackformat is more precise.So,
InfluxDBResultMapperhave errors. For example, it throws an exception when mapping number toint,Integer,long,Longtypes frommsgpackresponses, but works withjson.This PR fix it (with unit test).