Closed
Conversation
d74bfc1 to
5d95944
Compare
isuruf
reviewed
Sep 6, 2022
isuruf
reviewed
Sep 6, 2022
12 tasks
6 tasks
Owner
|
FYI I'm somewhere half-way resolving conflicts in this. |
inducer
reviewed
Dec 3, 2025
Owner
There was a problem hiding this comment.
Not sure I love that an explicit actx argument is necessary now. It might be better to have the actx globally in the toy context.
Collaborator
Author
There was a problem hiding this comment.
I'm very fine with that! Don't recall if I had any particular reason to make it explicit to each function (possibly to match P2P.__call__ and friends?).
9 tasks
Owner
|
Draft merge in #256. |
Owner
|
Continued in #256, closing here, since I can't seem to force-push here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get
sumpyon array contexts as well! This eats up the first commit from #118.Porting individual files
test_codegentest_csetest_distributedtest_fmmtest_kernelstest_matrixgentest_misctest_qbxtest_toolscurve-potcurveexpansion-toysfouriersym-exp-complexityRemaining porting issues
KernelCacheMixin.get_cached_executor(), which branches onOPT_ENABLED, but we need to move toactx.call_loopy.transform_loopy_program? Would need to also add some fancy tags or something to customize it?register_optimization_preamblesto the array context somehow too.actx.transform_loopy_programsomehow?Upstream / downstream PRs
Speculative TODOs
actx? Here e.g.SumpyTreeIndependentDataForWranglerbut also inboxtree.actx.*Builderclasses can be functions + all other memoized kernels can be functions, but should leave that for later since it can be done without breaking the world.boxtree?