Conversation
|
After writing most of this, I realized that there's some small conflicts with #118. I'm happy to resolve those if this gets in. |
88d7246 to
89adfcb
Compare
5cb55f4 to
f2e0696
Compare
|
@inducer This should be ready for a look! Most of it is just tedious, but there are a few things worth mentioning:
|
f2e0696 to
fa276fd
Compare
Do you remember which ones those were? Were they just random tolerance botches or something you thought was indicative of a deeper issue? (If the latter, could you file an issue?) |
|
This looks good to me, and it's an all-around improvement. Thanks! |
@inducer Looking through the failed CIs (e.g. https://github.com/inducer/sumpy/runs/7933601203?check_suite_focus=true)
so I would say it's just a case of fixing the tolerances to the previous seeds, but I don't know enough about what the tests are actually testing to be certain. |
Ports all the tests to the
arraycontextinfrastructure.This is not on top of #118 because it can go in without the rest of
sumpybeing ported.