Match text to renamed xref for missing-reference#2
Merged
inducer merged 1 commit intoinducer:mainfrom Aug 18, 2025
Merged
Conversation
alexfikl
commented
Aug 13, 2025
| node.attributes["reftype"] = reftype | ||
| node.attributes[f"{domain}:module"] = module | ||
|
|
||
| if isinstance(contnode, Text): |
Contributor
Author
There was a problem hiding this comment.
I added an else: breakpoint() here to check if this is ever not a Text and it doesn't seem to be the case.
I initially used TextElement because that's what the signature of domain.resolve_xref asked for below, but that seems to be a bug in the type annotations there.
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix things like
_Expressionshowing up in inducer/pymbolic#197 and some needlessly qualified names in inducer/pytential#271.