Attempt to make BcastUntilActxArray work for broadcastees that are containers#313
Open
majosm wants to merge 1 commit intoinducer:mainfrom
Open
Attempt to make BcastUntilActxArray work for broadcastees that are containers#313majosm wants to merge 1 commit intoinducer:mainfrom
BcastUntilActxArray work for broadcastees that are containers#313majosm wants to merge 1 commit intoinducer:mainfrom
Conversation
Owner
Could you explain? What does it mean if the timestep is a |
Collaborator
Author
It's from Tulio's local-timestepping stuff. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some mirgecom examples,
dtcan be aDOFArray. When using_compiled_lsrk45_stepfrom grudge (which now usesBcastUntilActxArrayforh, etc.), this causesdtto broadcast down to the array context arrays of the RHS container, leading to the creation of erroneous nestedDOFArrays. So it looks like we need to tweakBcastUntilActxArrayto handle the case ofbroadcasteebeing an array container.I took a stab at doing so here. I don't know if this is the right approach, but my hunch is that we should let the container's defined broadcasting behavior take over in this case (mainly because I feel like, e.g.,
bcast(Container()) + Container()ought to be equivalent toContainer() + Container()and not do any kind of broadcasting inside). Thoughts @inducer, @alexfikl?