move utils module here from gocd-s3-artifacts plugin#17
move utils module here from gocd-s3-artifacts plugin#17rucha3 wants to merge 5 commits intoindix:masterfrom
Conversation
There was a problem hiding this comment.
@rucha3 I know some code in gocd-s3-artifacts was written in Java because we didn't want to add Scala dependency to make the JAR heavy. But somehow the artifact plugin still ended up in Scala anyways. So, can we please consider moving these to Scala too? That way all the new places where we plan to use this would be in Scala. Some of the wrappers like Function, Functions, etc. can we completely removed and this would become much cleaner.
We can refactor or migrate the gocd-s3-artifacts plugin later to use this utils-gocd module.
build.sbt
Outdated
| scalaVersion := "2.11.11", | ||
| scalacOptions ++= Seq("-encoding", "UTF-8", "-deprecation", "-unchecked"), | ||
| javacOptions ++= Seq("-Xlint:deprecation", "-source", "1.7"), | ||
| javacOptions ++= Seq("-Xlint:deprecation", "-source", "1.8"), |
There was a problem hiding this comment.
Do we need to enforce 1.8? Scala 2.11 can work with 1.6. Forcing this to 1.8 might break compatibility with Scala 2.11 assumption. Unless we're using Lamdas' and Streams API introduced in JDK8.
There was a problem hiding this comment.
We are using lambdas in the gocd-util module. So, I put that in common settings. Should I make it module specific only?
There was a problem hiding this comment.
Ah Okay, see the above message on moving to Scala. If we decide to do that this comment becomes redundant.
|
Should ideal be a |
|
@ashwanthkumar We did not want to write these plugins in Scala because the jar became bloated, right? Why are now considering moving back to Scala? I'm guessing, we should be able to just package and deploy a java module from this repo and use that across all gocd plugins that we may develop. Thoughts? |
4 participants
No description provided.